vadykoo / boykottRussianBrands

2 stars 0 forks source link

Sweep: i want to save info about brands that was found on the current page and show the counter in the circle the same as Number of brands in popup #5

Open vadykoo opened 1 year ago

vadykoo commented 1 year ago

also, it has to be the counter in storage of all times that brand was found on the page, it has to add a counter of brands on this page after the page is loaded and the loop of searching brands is finished to storage counter

Checklist - [X] `content_script.js` ✅ Commit [`304c915`](https://github.com/vadykoo/boykottRussianBrands/commit/304c915922d8206ad1f55927c4c79323773a4f5d) - [X] `popup.js` ✅ Commit [`bb4625a`](https://github.com/vadykoo/boykottRussianBrands/commit/bb4625ad53b14f1b8653c39685f3e0e5809adadd)
sweep-ai[bot] commented 1 year ago

Here's the PR! https://github.com/vadykoo/boykottRussianBrands/pull/6.

⚡ Sweep Free Trial: I'm creating this ticket using GPT-4. You have 2 GPT-4 tickets left for the month and 2 for the day. For more GPT-4 tickets, visit [our payment portal.](https://buy.stripe.com/6oE5npbGVbhC97afZ4)

Actions (click)


Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/vadykoo/boykottRussianBrands/blob/d35f729e3e211482502cc5aeb0c30d423b1934ea/popup.js#L1-L107 https://github.com/vadykoo/boykottRussianBrands/blob/d35f729e3e211482502cc5aeb0c30d423b1934ea/content_script.js#L11-L333 https://github.com/vadykoo/boykottRussianBrands/blob/d35f729e3e211482502cc5aeb0c30d423b1934ea/background.js#L1-L111 https://github.com/vadykoo/boykottRussianBrands/blob/d35f729e3e211482502cc5aeb0c30d423b1934ea/popup.html#L1-L53

Step 2: ⌨️ Coding

trunk init 1/3 ✓
⡿ Downloading Trunk 1.16.1...
⡿ Downloading Trunk 1.16.1...
⢿ Downloading Trunk 1.16.1...
⣻ Downloading Trunk 1.16.1...
⣽ Downloading Trunk 1.16.1...
⣾ Downloading Trunk 1.16.1...
⣷ Downloading Trunk 1.16.1...
⣯ Downloading Trunk 1.16.1...
⣟ Downloading Trunk 1.16.1...
⡿ Downloading Trunk 1.16.1...
⢿ Downloading Trunk 1.16.1...
⣻ Downloading Trunk 1.16.1...
⣽ Downloading Trunk 1.16.1...
⣾ Downloading Trunk 1.16.1...
✔ Downloading Trunk 1.16.1... done
⡿ Verifying Trunk sha256...
✔ Verifying Trunk sha256... done
⡿ Unpacking Trunk...
✔ Unpacking Trunk... done

✔ 7 linters were enabled (.trunk/trunk.yaml)
  checkov 2.4.9 (1 json, 1 yaml file)
  git-diff-check (11 files)
  oxipng 8.0.0 (3 png files)
  prettier 3.0.3 (1 html, 3 javascript, 1 json, 1 yaml file)
  trivy 0.45.1 (1 yaml file)
  trufflehog 3.57.0 (11 files)
  yamllint 1.32.0 (1 yaml file) (created .yamllint.yaml)
Next Steps
 1. Read documentation
    Our documentation can be found at https://docs.trunk.io
 2. Get help and give feedback
    Join the Trunk community at https://slack.trunk.io
trunk fmt content_script.js 2/3 ✓

 ✔ Formatted content_script.js
Re-checking autofixed files...

Checked 1 file
✔ No issues
trunk check --fix content_script.js 3/3 ✓

Checked 1 file
✔ No issues

trunk init 1/3 ✓
⡿ Downloading Trunk 1.16.1...
⡿ Downloading Trunk 1.16.1...
⢿ Downloading Trunk 1.16.1...
⣻ Downloading Trunk 1.16.1...
⣽ Downloading Trunk 1.16.1...
⣾ Downloading Trunk 1.16.1...
⣷ Downloading Trunk 1.16.1...
⣯ Downloading Trunk 1.16.1...
⣟ Downloading Trunk 1.16.1...
⡿ Downloading Trunk 1.16.1...
⢿ Downloading Trunk 1.16.1...
⣻ Downloading Trunk 1.16.1...
⣽ Downloading Trunk 1.16.1...
⣾ Downloading Trunk 1.16.1...
✔ Downloading Trunk 1.16.1... done
⡿ Verifying Trunk sha256...
✔ Verifying Trunk sha256... done
⡿ Unpacking Trunk...
✔ Unpacking Trunk... done

✔ 7 linters were enabled (.trunk/trunk.yaml)
  checkov 2.4.9 (1 json, 1 yaml file)
  git-diff-check (11 files)
  oxipng 8.0.0 (3 png files)
  prettier 3.0.3 (1 html, 3 javascript, 1 json, 1 yaml file)
  trivy 0.45.1 (1 yaml file)
  trufflehog 3.57.0 (11 files)
  yamllint 1.32.0 (1 yaml file) (created .yamllint.yaml)
Next Steps
 1. Read documentation
    Our documentation can be found at https://docs.trunk.io
 2. Get help and give feedback
    Join the Trunk community at https://slack.trunk.io
trunk fmt popup.js 2/3 ✓

 ✔ Formatted popup.js
Re-checking autofixed files...

Checked 1 file
✔ No issues
trunk check --fix popup.js 3/3 ✓

Checked 1 file
✔ No issues


Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/brand-counter.

.


🎉 Latest improvements to Sweep:


💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. Join Our Discord