search

vadymmarkov / Beethoven

:guitar: A maestro of pitch detection.
https://github.com/vadymmarkov
Other
827 stars 146 forks source link

A way to monitor mic input level and set a threshold on it ? #25

Closed glaurent closed 8 years ago

glaurent commented 8 years ago

Hi,

Trying the Guitar Tuner example, I find that it detects pitches just out of the base level of noise that the microphone gets. So I'm looking for a way to "filter out" low level signals so that detection would only occur if the input level is above a certain value. I don't know much about AVAudio yet, so I'm asking if you have an idea on how to do this (or are planning to do it) before I dive into docs :)

Thanks

glaurent commented 8 years ago

I could implement this feature for the InputSignalTracker but not the OutputSignalTracker. I've tried submitted a pull request but apparently I don't have permission.

vadymmarkov commented 8 years ago

Hi @glaurent! Thanks for reaching out. Would love to look at your implementation of this feature. You can make a fork of the repo and then you'll be able to submit a PR here.

glaurent commented 8 years ago

Pull-request made :) thanks.

vadymmarkov commented 8 years ago

Fixed by https://github.com/vadymmarkov/Beethoven/pull/26