search

vadymmarkov / Beethoven

:guitar: A maestro of pitch detection.
https://github.com/vadymmarkov
Other
824 stars 146 forks source link

Refactor/transform strategy #40

Closed vadymmarkov closed 8 years ago

vadymmarkov commented 8 years ago

There is a list of changes that I'm planning to include in the next major release.

1) Add Travis. 2) Use SwiftLint to enforce Swift style and conventions. 3) Refactor project structure and code. 4) Remove public and open access modifiers to make public API cleaner. 4) Breaking API change: Remove transform from Config, as @glaurent suggested. From now transformer should be specified in order to conform to Estimator protocol:

protocol Estimator {
  var transformer: Transformer { get }
  // ...
}

5) Update README.

vadymmarkov commented 8 years ago

@glaurent I've got a chance to test demo with YIN algorithm on my acoustic guitar and it works way better than HPS 🎉

glaurent commented 8 years ago

@vadymmarkov yay 👍