search

vadymmarkov / Malibu

:surfer: Malibu is a networking library built on promises
https://vadymmarkov.github.io
Other
414 stars 39 forks source link

Improve: request convertable base url #62

Closed vadymmarkov closed 7 years ago

vadymmarkov commented 7 years ago

This PR aims to fix https://github.com/hyperoslo/Malibu/issues/61 by making baseUrl in RequestConvertible optional.

static var baseUrl: URLStringConvertible? { get }

let backfootSurfer = Networking<AnyEndpoint>() didn't work before because its baseUrl was an empty string, which is wrong and breaks the logic of building the final request URL. And actually I think it makes sense to have optional baseUrl in RequestConvertible implementations, for cases when you want to group requests without any shared host.

onmyway133 commented 7 years ago

🎏