vaendryl / Sunrider

source code of the visual novel 'Sunrider'
http://sunrider-vn.com/
41 stars 21 forks source link

Start to use ship ids for comparison #143

Closed DoumanAsh closed 9 years ago

DoumanAsh commented 9 years ago

If we assume that id is unique it is sufficient to compare ships by their ids.

Question is, though, do we need it? I didn't look too much into code, but i assume mostly in Sunrider we're copying around references to ships or is there place where we need a actual comparison?

By default if there are no such methods Python compares objects by addresses

vaendryl commented 9 years ago

I don't really think this is required and just ads more complexity in which things can go wrong

DoumanAsh commented 9 years ago

Ok, I think you can actually remove it as it is not really used, at least at first glance