search

vaendryl / Sunrider

source code of the visual novel 'Sunrider'
http://sunrider-vn.com/
41 stars 21 forks source link

Unify return values of ui.interact() #37

Closed DoumanAsh closed 10 years ago

DoumanAsh commented 10 years ago

My suggestion is to simplify handling of ui.interact() with unification of return values. Instead of string and lists use only lists. True/False/None are ok i guess

p.s. i'm going to start implement my previous big commit with by small parts and that's going to be first of them

vaendryl commented 10 years ago

I see a ton of changes and honestly that scares the crap out of me. just testing this properly would take hours. I also don't notice a new result handler in this code

DoumanAsh commented 10 years ago

New handles will be later, i dont wanna make commit with over 1k changes.... I will make the same handler via dictionaries as in my previous commit for battle management improvement which was abonded by me

EnderShadow commented 10 years ago

I like where this is going. There's a mistake in the galaxy map though. You reset the label but not the mission name at the start of the file

DoumanAsh commented 10 years ago

Not sure if i got you right. I just replaced some code to make instead of 3 IFs only 1... So point me with comment where is mistake. Found, it's originally was designed with mistake. Anyway hope that someone will test that...

vaendryl commented 10 years ago

this pull can no longer be automatically merged. any idea what the easiest way would be to merge it anyway?

DoumanAsh commented 10 years ago

The easiest way is to rebase and to solve conflicts. I can do that but it can take a while since someone re-written classes pretty hard....

DoumanAsh commented 10 years ago

Rebased Hm.. i'm thinking that we should wrap: skirmish_dispatcher[self.result[0]]() into 'try...except....' to handle True, False, None values

vaendryl commented 10 years ago

allright, let's try this.