search

vaendryl / Sunrider

source code of the visual novel 'Sunrider'
http://sunrider-vn.com/
41 stars 21 forks source link

AI Changes - consider closing in #64

Closed BlueOrange closed 9 years ago

BlueOrange commented 9 years ago

The 'AI Considers advancing before firing' change seemed interesting, and trying to design a skills architecture was doing my head in.

I've removed the try...except thing from the Dispatcher, because my AI code was throwing type errors, and the try...except was doing my head in.

vaendryl commented 9 years ago

looks interesting :p

the deal with the pass statements in the combat screen is something that's part of renpy version 6.18 onwards. you should update your SDK to the latest version and revert those changes.

BlueOrange commented 9 years ago

Ah yes, done.

Why you poke your tongue? :)

DoumanAsh commented 9 years ago

oh lol so much commits... And you do understand that when you removed try...except from dispatchers you leave possibility of TypeError when Bool/None is returned? Also TypeError is specifically written for such case. I even added check to be sure that needed exception is catched. So move it back or make some proper replacement.(by proper i mean performance-wise) If your code throw exceptions you should handle them inside of your code.

p.s. it is ofc if you want to remove it permanently

DoumanAsh commented 9 years ago

General suggestion Orange. You should keep your repository up-to-date with Vaendryl...

vaendryl commented 9 years ago

it's already un-mergeable XD I blame Douman's battle log!

DoumanAsh commented 9 years ago

Well of course with so much changes. But it is the best just update repository often and not on occasions :)

BlueOrange commented 9 years ago

Auto-merge was working before V made his commits while I was sleeping! But yes, keeping up to date is good practice. I'm accustomed to having my desktop tool warn me about these things. But working in a fork means that SmartGit will need some persuasion before that's possible.

BlueOrange commented 9 years ago

Twas the change to the exception handler that broke the auto-merge. (And I choose to pout at Douman, since I was fully synced with the main fork, up until midnight my time. Stupid timezones.)

BlueOrange commented 9 years ago

I've changed the exception handling for dispatcher lookup so that it no longer suppresses exceptions throughout the codebase, and is less likely to throw an exception in the first place. Couldn't test for skirmish and formations, because I don't have the CB assets. Changes are simple enough that I'm confident.