search

vaendryl / Sunrider

source code of the visual novel 'Sunrider'
http://sunrider-vn.com/
41 stars 21 forks source link

Remove use of $continue. #9

Closed renpytom closed 9 years ago

renpytom commented 10 years ago

$continue is not valid screen language code, since there isn't a python for loop here.

Ren'Py 6.18, which includes a faster reimplementation of screen language, won't be able to process a $continue, as it no longer comples SL directly to Python code. This change will make it possible to run Sunrider under a newer Ren'Py.

renpytom commented 10 years ago

You'll want to wait until 6.18 is in testing to apply this, since it's not valid SL yet.

vaendryl commented 10 years ago

thanks for the heads up!

I'm rather worried though, as I use quite a bit of python liberally through all of my screen language! :S is it likely other things will also stop working, or is it just the interaction between a SL for loop and a python flow control?

renpytom commented 10 years ago

As long as python/$ blocks are syntactically valid python - standalone - they will work. You'll have problems if you use continue/break/return inside an SL python block, since we no longer compile SL to a function.

vaendryl commented 9 years ago

changes are manually added to master.