search

vaendryl / Sunrider

source code of the visual novel 'Sunrider'
http://sunrider-vn.com/
41 stars 21 forks source link

moving next to a disabled unit shows counter animation and an error #96

Closed vaendryl closed 9 years ago

vaendryl commented 9 years ago

http://steamcommunity.com/app/313730/discussions/0/616189742903135141

Quickman commented 9 years ago

Took a look at it, figured it out, tested it, fix works. It's... dumb, really dumb.

I noticed that the get_counter_attack function and displaying squares to move in was working, but counters weren't. Compared the code used in determining safe squares and for determining counter attack. One checks and works

ship.modifiers['flak'][0] != -100:

but the actual check uses

enemy.modifiers['flak'] != -100:

If you just add a [0] after [flak], it works fine (tested, seems fine, regular CAs still work I believe and disabled ones/flakminused ones don't). I haven't actually looked at the code enough to determine how or why this works (and I don't have a bloody clue myself what half this stuff means).

...Also, looking at the code, this means that flakoff'd enemies can't counter, correct? ...Is that in the tooltip? Is that even intended? I'd guess but meh.

I'll upload a fix in a moment.

Quickman commented 9 years ago

Turns out that 'flak shuts off counters is in the beta 7 changelog' Well, aren't I good at reading comprehension?

vaendryl commented 9 years ago

Thanks man! It needs the [0] because the value stored in the dict is [ mod_strength , duration ]