vaenow / cordova-plugin-app-update

App updater for Cordova/PhoneGap
MIT License
299 stars 146 forks source link

Change Language #46

Closed cPerdereau closed 6 years ago

cPerdereau commented 6 years ago

Hello is it possible to change plugin language for French ? I saw the XML but i dont wanna have to change the xml in node_modules!

vaenow commented 6 years ago

Maybe you should fork it and make your own language

referer: https://github.com/vaenow/cordova-plugin-app-update/issues/9

cPerdereau commented 6 years ago

Hello, thanks, can you warn me when its available after i created it, so i can try to npm update please?

:D thanks a lot

vaenow commented 6 years ago

@cPerdereau

Language Fr has already been published on npm

cPerdereau commented 6 years ago

Great ! Thanks a lot :) :+1:

cPerdereau commented 6 years ago

Errmm..

How do you trigger the French language, it's still in English for me :s and Globalization tells me locale is FR.. :(

vaenow commented 6 years ago

refer: https://github.com/vaenow/cordova-plugin-app-update/pull/10#issuecomment-245311705

Android will automatic choose the language depends on your phone setting.

Is there something I missed in the Fr pull request?

cPerdereau commented 6 years ago

Ok it seems to be working, i make a new request, i think you changed to 'google translate French' can you use my file please?

Edit: Damn, it's not working actually. In node_modules, i can see the values-fr folder, but if i clean Android folder and rebuild Android, only 'values' / 'values-en' / 'values-zh' are getting installed... :'(

vaenow commented 6 years ago

Oh! my fault! i forgot a configuration in file https://github.com/vaenow/cordova-plugin-app-update/blob/8bdf884358229e98c56bcfbc0fbad9364241bf95/plugin.xml#L42

cPerdereau commented 6 years ago

I think it's still the same, no values-fr :-/

vaenow commented 6 years ago

I dont have a PC now, I can only fix this issue tomorrow morning.

cPerdereau commented 6 years ago

It's ok! I'll wait don't worry ;) have a nice day !! thanks a lot :)

vaenow commented 6 years ago

@cPerdereau It seems working now. please have a try.

cPerdereau commented 6 years ago

Ok thanks, i'll try tomorrow morning ! thanks a lot :

cPerdereau commented 6 years ago

Hello ! ok it works now ! But can you update my XML plz ? cause it wasnt right

vaenow commented 6 years ago

The npm 1.4.3 already published. 🙂