search

vaenow / cordova-plugin-app-update

App updater for Cordova/PhoneGap
MIT License
299 stars 146 forks source link

AutoUpdate without prompt: immediate App restart #78

Open carlo318 opened 6 years ago

carlo318 commented 6 years ago

With this modification the app is able to AutoUpdate and Restart without the prompt "The App needs to be updated", that is without the need for the user to tap on button "Update". The App AutoUpdates and Restarts by itself, without any user interaction.

vaenow commented 6 years ago

@carlo318

Sorry, I cannot accept this PR.

Everyone has his own needs, so you must make Immediate update as an optional parameter. https://github.com/vaenow/cordova-plugin-app-update/blob/0211b6d86f1d3abffcd65e910a649be9b6c15faa/www/AppUpdate.js#L14

Look forward to your next Pull Request 🙂

carlo318 commented 6 years ago

You are right, I have committed, in my branch, the version that suits my needs. For sure, It's better to add a parameter.

But it seems not very clear to put this kind of parameter in authentication options. Anyway, if you think it's fine to put it there, I will do it. Thankyou. Carlo

carlo318 commented 6 years ago

Please let me know if the new parameter skipPrompt is fine. Thanks.

ranaavneet89 commented 4 years ago

Hey guys!, Is this PR merged?