search

vaenow / cordova-plugin-app-update

App updater for Cordova/PhoneGap
MIT License
298 stars 146 forks source link

Prevent INSTALL_FAILED_CONFLICTING_PROVIDER error again! #80

Closed loban closed 6 years ago

loban commented 6 years ago

I had previously made a pull request to fix this problem, which occurs if you try to install two cordova apps with this plugin, due to a conflicting hard-coded provider name specified in plugin.xml. The solution was to make the provider name dynamic (using applicationId).

However, several commits later, the fix was removed due to additional java code that could not handle the dynamic provider name. This patch both re-applies the dynamic provider, and adds java code to handle it.

This fixes issue #67.

I had previously made an erroneous pull request #79 from the wrong branch (which I have now closed). This pull request is the correct one!

loban commented 6 years ago

Any comments on this? Been using my fork for awhile with no problems, but would love for the fix to go into the mainline.

vaenow commented 6 years ago

Test passed in Nexus 5 Thank you guys 👍

loban commented 6 years ago

Thanks for the merge! Now I can discontinue my temporary fork and go back to using mainline.

On Fri, 26 Jan, 2018 at 6:46 PM, Wen Luo notifications@github.com wrote:

Test passed in Nexus 5 Thank you guys 👍

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vaenow/cordova-plugin-app-update/pull/80#issuecomment-360775655, or mute the thread https://github.com/notifications/unsubscribe-auth/ABkdYxAY745UXN2SGhpiGGddU6NArfCwks5tOckbgaJpZM4RL1aA .