search

vaerh / mikrotik-prom-exporter

0 stars 0 forks source link

Poc2 #2

Closed jlpedrosa closed 5 months ago

jlpedrosa commented 6 months ago

Your code

vaerh commented 6 months ago

I'll recover a bit from the routeros and we'll continue.

jlpedrosa commented 6 months ago

No rush, I'm going crazy also here with my home lab.....

jlpedrosa commented 5 months ago

I am super busy this week, maybe on sunday I an get to this.... sorry.

vaerh commented 5 months ago

No problem, I have a big workload too.

jlpedrosa commented 5 months ago

Hey! I'm kind of back. Should I review this and we adding features?

vaerh commented 5 months ago

Hi, that's good news! I suggest doing a review, but not merging branches yet. I too want to see what I did 2 weeks ago.

vaerh commented 5 months ago

I tried to remember where I left off last time, but I couldn't, there was a lot of code in that time. The only two things that came to mind were that the current implementation doesn't take into account serving more than one router (the labels are static address and router name), and that I wanted to tackle CAPsMAN but didn't have time. Is it relevant to you?

jlpedrosa commented 5 months ago

Hey! no problem, we can fix it after the fact. We are not reelasing anything (yet).

The static router is an important thingy, we need to add a arg+env variable to set it up. Let me create later some issues what the items that needs to be done so we keep track of it.