search

vaersaagod / seomate

SEO, mate! It's important. That's why SEOMate provides the tools you need to craft all the meta tags, sitemaps and JSON-LD microdata you need - in one highly configurable, open and friendly package - with a super-light footprint.
MIT License
36 stars 8 forks source link

Craft 3.2 Support #12

Closed Mosnar closed 5 years ago

Mosnar commented 5 years ago

I was taking some time to test this plugin for Craft 3.2 and it doesn't look like it's quite there. Particularly, the Live Preview functionality appears to be broken.

I started digging into it and found that the first issue is that the "Live Preview" button ID changed in 3.2, so that will need to be updated to:

var $lpBtn = $('#preview-btn');

After changing this, the button appeared as expected; however, clicking did nothing. I have not tested actual plugin rendering functionality yet; however, I that part doesn't seem likely to have broken.

Edit After additional digging, it looks like the LivePreview class is deprecated and the entire system is rewritten, so this may be a bit of a headache to fix.

mmikkel commented 5 years ago

This should be resolved in SEOMate v1.0.5.