vaeth / bookmarkdupes

A WebExtension which can display/remove duplicate bookmarks or empty folders
https://addons.mozilla.org/en-US/firefox/addon/bookmark-dupes/
119 stars 11 forks source link

Announcements to all contributors #13

Open vaeth opened 6 years ago

vaeth commented 6 years ago

In that bug, I will regularly announce if something notably changed.

In the moment, there are two announcements necessary:

  1. In order to fix leakage of private data, I had to rebase just now. If you had pulled within the last 24 hours or so, please rebase, too. (I suppose you will have to use something along git fetch, git reset --hard ... and then later push with git push --force; perhaps github provides also other options). I am sorry about that, and I hope that this rebase of the main repository will be the sole exception.

  2. Two new buttons were added. I added the new messages (untranslated) to all _locale/*/messages.json files. Please drop me a note if you prefer that I do this differently in the future. (E.g. if you prefer to not have modified that files when new messages are added.)

perdolka commented 6 years ago

I added the new messages (untranslated)

This is the best way for translators, it seems to me. I will translate a little later.

juaalta commented 6 years ago

I added the new messages (untranslated)

It would be interesting that new translations were at the end of the file, in this way it would be easier to find them.

vaeth commented 6 years ago

(I did not mean to edit your reply - i just had pressed the wrong button by mistake. I restored your message again)

new translations were at the end of the file

This could make the order somewhat confusing. I just verified that firefox accepts // type comments in these files, so I might add some // new or // changed comment to new/changed messages. I suppose that this is easy to spot with any editor.

vaeth commented 6 years ago

I added some new texts. It is intentional that the button with the intrusive action appears after the new verbose explanations: I hope that this minimizes the risk of pressing it accidentally.

An alternative would be to hide these texts initially and let them pop up once the button is pressed as some sort of "are you sure" confirmation (requiring a second button to be pressed). However, this might be rather annoying and will not necessarily prevent accidental pressing either (once the user gets accustomed to it).

vaeth commented 6 years ago

In order to process with #22 as quickly as possible, I think that I will make a release 2.4 rather soon (perhaps today) even if some texts are not translated yet. A follow-up release can still be made only for the translations...

vaeth commented 6 years ago

Unless there are new bugs reported, I would like to release bookmarks-dupes-4.0 soon (on 23rd).

Please note that in every language there is in the moment at least one untranslated string. ("messageNoCount": The text which is shown when the user switches off counting of marks.)

As usual, please do not feel offended or obliged to be quick with the translations: Translations can easily be updated in a minor release.

vaeth commented 6 years ago

Unfortunately, yet another rebase was necessary

vaeth commented 6 years ago

I am sorry, but I added a new feature which requires again quite some translations.

I had observed that the case for which I used bookmarks dupes personally was not easily covered: In certain situations related with sharing firefox profiles and syncing (no need to go into details here), it can easily happen that identical or renamed bookmarks appear twice in the same folder; so I had missed a button to mark only such type of dupes while keeping other dupes intentionally.

vaeth commented 6 years ago

IMHO bookmarkdupes-5.0 is now feature complete, and during testing, I found no bugs. So I think it is time to release it. I will still wait a few days for possible translations, but as usual don't feel pressed, since translation updates can come in the next minor release.

Please excuse that just today I had to add new messages and permissions (for the storage buttons; for power users who might want to setup tricky rules this is probably an almost necessary feature).

Also I had to modify a few messages which I just had added a few days ago, because I realized that firefox already forces protocol and domain names to be lowercase in bookmarks, so it is not a good idea to apply this transformation unconditionally: This has now just become a transparent and optional default rule for the expert mode.

vaeth commented 6 years ago

I have changed my mind after realizing that it is very inconvenient to have no "official" way to sync rules between browsers. So the new version now also supports the brower's sync storage area if a corresponding firefox version is used (53 or newer). I will correspondingly postpone the release somewhat.

The new feature not only gave rise to new buttons/messages but also required modifying the previous buttons/message for storage handling slightly for consistency reasons.

BTW, probably you realized that I had changed the texts on some buttons to UTF8 pictograms. I am not sure whether this was a clever idea, but my motivation was:

  1. Save space on displayed buttons: Especially the rules did not fit on browsers on smaller screens.
  2. Make sure similar things look similar: At least in English the button texts would become very long if they should look similar with just "local" and "sync" replaced.
  3. For power users maybe buttons can be identified quicker if pictograms are used: I realized that after a while (when becoming unconcentrated) I sometimes pressed the wrong button because of "too lazy" reading.

Please do not feel obliged for translations to use the same pictograms or even to use pictograms at all. I am aware that there may be several good reasons for this:

  1. Perhaps in languages with non-latin characters such pictograms are just confusing.
  2. Perhaps the pictograms do not have the same interpretation in the corresponding culture.
  3. Perhaps the corresponding culture is so literate that people might feel offended seeing pictograms instead of a well-written text.

Anyway, in the English text I decided for the pictograms, and currently even for the German translation despite 3 applies...

vaeth commented 6 years ago

A new version is about to be released, soon. Mainly, there is one new feature: It is possible to move the dupes (or empty folders) to a trash folder “dupes” instead of removing them.

There are a few related new messages involved: Essentially, these are messages which previously existed, but the word "remove" replaced by "move" (perhaps in other languages the change is not so simple.). And also the name of the “dupes” folder (and a rule to match it) can be translated…

vaeth commented 4 years ago

A new version is about to be released, soon.

There is one new feature: A button to display (and remove from) a list of non-dupe bookmarks. There are 4 new messages: The button, the number (and total) of displayed bookmarks, and the respective titles (popup texts). As usual, I marked them with "// new".

vaeth commented 4 years ago

Again, a new version is supposed to be released.

There is only one new feature: One can now use $&$TITLE, $TITLE$&, $&$NAME, $NAME$&, $&URL, and $URL$&, for the replacement text with the obvious meanings (e.g. the first means that $TITLE is appended to the match).

I added a sentence with the English version of this extension to all languages and put a comment "// new" behind the corresponding modified line.

As usual, I will wait some time for the translations before I release the new version. Thank you in advance for the translations.

Best Regards Martin