Open yohplala opened 2 years ago
Hi,
thanks for the report! @JovanVeljanoski i think this is expected behaviour, but I personally hate it, I think the prefix/suffix should always be used, but as it is now, it's only used when the column names collide. My guess this comes from pandas compatibility, but I'm happy to change this, if @JovanVeljanoski agrees, and someone wants to write a test for this.
cheers,
Maarten
Description Conducting
join
operations in a loop, while usingrprefix
parameter, I noticed that this parameter is not systematically used, always for the 2nd iteration of the loop. Why is that so?Minimal Reproducible Example
The
print
statements displaysrprefix
and the resulting column names as the vaex DataFrameleft
gets new columns, only for the first 3 iterations. It displays:The trouble is the 2nd paragraph (2nd iteration). You can read
'x_0', 'x_1', 'x_2'
, which shows thatrprefix
is not used for this 2nd iteration. Expected column names should be'vdf_1_x_0', 'vdf_1_x_1', 'vdf_1_x_2'
.We can see that with the 3rd iteration,
rprefix
is used ok. (and so for the following iterations)Please, is this a bug?
Software information
{'vaex-core': '4.5.1', 'vaex-hdf5': '0.10.0', 'vaex-ml': '0.14.0'}