Fix: count with binning using multiple selections

vaexio / vaex

Out-of-Core hybrid Apache Arrow/NumPy DataFrame for Python, ML, visualization and exploration of big tabular data at a billion rows per second 🚀

https://vaex.io

MIT License

8.25k stars 590 forks source link

Fix: count with binning using multiple selections #2152

Open JovanVeljanoski opened 2 years ago

JovanVeljanoski commented 2 years ago

Closes: https://github.com/vaexio/vaex/issues/2151

[x] Implement a test
[ ] test passes

maartenbreddels commented 2 years ago

Ok, had to think about this, but I'm not sure what to do here.

a single aggregation will only be done on a 'fixed grid', so for both selections the same min and max. At some point, we started respecting the selection for the min and max of the binby grid, now I think this was a mistake, because we painted ourselves in a corner. We cannot have two different limits for the two different selections.

maartenbreddels commented 2 years ago

@JovanVeljanoski we discussed this privately, do you remember what we decided?