vaexio / vaex

Out-of-Core hybrid Apache Arrow/NumPy DataFrame for Python, ML, visualization and exploration of big tabular data at a billion rows per second 🚀
https://vaex.io
MIT License
8.23k stars 590 forks source link

Add a `__dataframe__` method to `_VaexDataFrame` #2205

Closed rgommers closed 1 year ago

rgommers commented 1 year ago

This will align the implementation with those in other libraries, xref https://github.com/data-apis/dataframe-api/issues/80.

Cc @maartenbreddels, @honno

rgommers commented 1 year ago

(apologies for iterating in CI, I was a bit too lazy to set up a dev environment for these few lines of code)

rgommers commented 1 year ago

This seems happy now, the 4 CI failures I inspected are all HTTPClientError: HTTP 502: Bad Gateway.

honno commented 1 year ago

FWIW dataframe_protocol_tests.py and the relevant dunder-df tests in dataframe-interchange-tests pass for this PR locally.

(If the bad gateway stuff gets resolved, note there's other issues with interchange stuff on win/mac CI https://github.com/vaexio/vaex/pull/2150#issuecomment-1237847383)

rgommers commented 1 year ago

@maartenbreddels I somehow keep getting notifications for new failures on reruns of CI jobs. No worries if you are doing that on purpose - if not, something is probably off in the GitHub Actions config in this repo.

The only failures are still (7x):

FAILED tests/viz_test.py::test_heatmap_with_what[webserver_fastapi-ds_filtered-tornado_client]
maartenbreddels commented 1 year ago

Yeah, that was me :) I had to rebase, hopefully it is green now.

maartenbreddels commented 1 year ago

green enough, thanks Ralf!

rgommers commented 1 year ago

great, thanks!