search

vaginessa / gmapcatcher

Automatically exported from code.google.com/p/gmapcatcher
0 stars 0 forks source link

Code review request #278

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Purpose of code changes on this branch:
1) Ruler: Since F7 was unused, I have used it for toggling Ruler mode on and 
off. The status bar has been used to display segment distance and total 
distance. One can keep on clicking to add segments of straight lines to find 
out the distance.

2) Smaller Marker: Since I found the marker.png to be too huge, added a 50% 
size of this image with a new name marker_s.png.

3) Marker Name: Displaying the marker name in the map instead of only Markers.

When reviewing my code changes, please focus on:

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by benx...@gmail.com on 18 Sep 2011 at 5:52

Attachments:

GoogleCodeExporter commented 9 years ago 
Enter your changes on the trunk, we will review there

Original comment by heldersepu on 18 Sep 2011 at 7:08

GoogleCodeExporter commented 9 years ago 
Committed the changes. Ist time python and SVN user. hope I did not do any
mistake.

Original comment by benx...@gmail.com on 18 Sep 2011 at 8:06

GoogleCodeExporter commented 9 years ago 
Honestly I do not like the new feature that the marker displays the name, if 
you really want that, you can add it as an option but please by default keep it 
off.
the best will be to display an "info window" or toolTip, we had some ideas 
about that see Issue 75.

Also the use Ruler feature behaves strange see the attached image. I have the 
status bar type = None

Original comment by heldersepu on 19 Sep 2011 at 12:52

Attachments:

GoogleCodeExporter commented 9 years ago 
Ok, will make it off by default. Since I go off-roading a lot with GPS and no 
internet, I make these way-points (markers) so that I know where I am. That is 
why when the marker name is displayed I know where I am or where I need to head 
to.

The ruler displays temporary lines (repaints) as the mouse moves displaying the 
current segment and current segment distance as well as the total distance in 
the status bar. Segments are created at each right-click of the mouse so we can 
know the approximate distance between two points. Will modify it to show the 
segments while the ruler mode is on and reset/clear it when F7 is pressed

Original comment by benx...@gmail.com on 19 Sep 2011 at 6:46

GoogleCodeExporter commented 9 years ago 
Yes please do that, the name of the markers can be very obstructive when there 
are a lot of markers together. If I have some time I will get you a head 
start...

The F7 feature i'm not sure how it works, can you please give us some more 
details on the intended behavior.

Thank you, 
Helder

Original comment by heldersepu on 20 Sep 2011 at 12:05

GoogleCodeExporter commented 9 years ago 
in your ".conf" file there will be a new line:
show_marker_name = False
you can change it to True to draw the pango Layout with the Marker info.
see r1152 for more details

Original comment by heldersepu on 20 Sep 2011 at 12:39

GoogleCodeExporter commented 9 years ago 
Sent you maps.py and widDrawingArea.py by email and will commit them after more 
work is done.

In real time we use markers for unknown places and there are many roads yet to 
be updated in maps which are missing. Will be using this software on-road next 
week :)

Original comment by benx...@gmail.com on 26 Sep 2011 at 8:38

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by heldersepu on 30 Sep 2012 at 8:08