search

vagnum08 / cpupower-gui

cpupower-gui is a graphical program that is used to change the scaling frequency limits of the cpu, similar to cpupower.
GNU General Public License v3.0
430 stars 31 forks source link

Fix #100 #101

Closed bill88t closed 1 year ago

bill88t commented 1 year ago

Closes #100

bill88t commented 1 year ago

Hmm, turns out it doesn't quite set frequences correctly now.. Gimme 5.

bill88t commented 1 year ago

Fixed freq, offline values are now 0. The frequences were alright, yet somehow ryzen boost even with the powersave scheduler.

Additionally applied psf/black codestyle for all python files. This will not affect how the code functions. Standard code styles are really important. I also suggest you setup a pre-commit hook for the repo. If you want me to do this, just tell me to do so and i will do it in a followup pr.

vagnum08 commented 1 year ago

+1 for black.

I use black too. I have set my code editor to run black on save.

I was maintaining an internal project that was using pre-commit and usually the collaborators were finding ways to skip it. I ended up setting up a pipeline on GitLab that was running black before the tests.

So I think it might worth checking how to do this on pull requests on GitHub.

bill88t commented 1 year ago

I'll take this as a go ahead. I will make a seperate pr in a bit.

As for this pr, i'm done.

vagnum08 commented 1 year ago

Thank you for fixing this bug, and in such a short time!