search

vagran / dxf-viewer-example-src

Source for dxf-viewer-example GitHub pages repository
MIT License
47 stars 27 forks source link

Typescript errors in version 1.0.26 #16

Open artjom-inspirators opened 1 year ago

artjom-inspirators commented 1 year ago

Issue: TypeScript Errors and Breakage after Updating to Version 1.0.26

Description: I updated the dxf-viewer package in my Angular application from version 1.0.22 to the latest version (1.0.26), and I encountered TypeScript errors and breakage in functionality.

Steps to Reproduce:

Update the dxf-viewer package in an Angular application from version 1.0.22 to the latest version (1.0.26). Build and run the application. Observe the TypeScript errors and issues in the functionality.

Observed Issues:

Error: node_modules/dxf-viewer/src/index.d.ts:83:42 - error TS2371: A parameter initializer is only allowed in a function or constructor implementation.
constructor(lines: PatternLineDef[], name: string | null = null)

Error: node_modules/dxf-viewer/src/index.d.ts:88:51 - error TS2371: A parameter initializer is only allowed in a function or constructor implementation.
export function RegisterPattern(pattern: Pattern, isMetric: boolean = true): void

Error: node_modules/dxf-viewer/src/index.d.ts:91:45 - error TS2371: A parameter initializer is only allowed in a function or constructor implementation.
export function LookupPattern(name: string, isMetric: boolean = true): Pattern | null
vagran commented 1 year ago

Thanks for the report! Please check fix in v1.0.27.