search

vagran / dxf-viewer

DXF 2D viewer written in JavaScript
Mozilla Public License 2.0
290 stars 86 forks source link

Various MText improvements and small fixes #104

Open tth05 opened 4 months ago

tth05 commented 4 months ago

Almost forgot about this, I hope the commits are somewhat self-explanatory. Let me know if anything should be changed, although I never want to work with JS again. Would be great to see the TS port and new parser completed.

I used https://github.com/mozman/ezdxf/blob/master/docs/source/dxfinternals/entities/mtext.rst and https://github.com/skymakerolof/dxf/blob/develop/src/handlers/entity/mtext.js as references to figure stuff out and of course just playing around in AutoCAD.

I've attached a file which can be used to compare the before and after, mostly regarding MText columns. AutoCAD reference: image columns-all.dxf.txt

tth05 commented 2 months ago

@vagran Have you looked at this yet?

vagran commented 2 months ago

@vagran Have you looked at this yet?

I took a look, and found it is quite a lot of changes from various areas. So it is still postponed for full review and most probably some refactoring, understanding and testing each change. PR has higher chance to be merged quickly if it fixes some single problem.

tth05 commented 2 months ago

Ok, no problem. Just didn't want to let this go to waste