search

vagran / dxf-viewer

DXF 2D viewer written in JavaScript
Mozilla Public License 2.0
295 stars 87 forks source link

add GetCreatedControllers method #23

Closed dotoritos-kim closed 1 year ago

dotoritos-kim commented 1 year ago

I found a bug related to camera zoom in and zoom out, and I want to be able to control it externally. If the zoom-out level was too high, the drawing could never be viewed again.

vagran commented 1 year ago

I am not sure these changes are needed in the public API. OrbitControl is a kind of internal class which is not a part of the public API. If you have found a bug there, please propose a fix for it or create a separate issue with the recreation scenario. Blocks as well are not usable outside the viewer. For proper display of sheets a separate API will be planned, it must account things like separation between model and paper space, potentially different scales, viewports support and so on. Until it is done you can either have a fork with required changes, or just access some viewer internals directly without accessor methods.