Some entities not rendered

vagran / dxf-viewer

DXF 2D viewer written in JavaScript

Mozilla Public License 2.0

295 stars 87 forks source link

Some entities not rendered #5

Closed AsiaMartini closed 2 years ago

AsiaMartini commented 2 years ago

When I try to load the same file in your deployed demo and in my project (not Vue), results are different. This is the result of your deployed demo:

This is my project output (as you can see, some entities are missing):

What could I have done wrong? I see no errors in console. Thanks.

vagran commented 2 years ago

It is quite difficult to say what can be a problem just by these pictures. Vue itself does not add anything to the rendering, it was used just to illustrate how to use the library with some popular framework.

Leessonomy commented 2 years ago

I have a similar problem. @vagran This is the only problem because of which I'm wary of using your library

Thanks

test1 test2

vagran commented 2 years ago

As I see you have a problem with multiline text and some solids (probably 3DFACE or 3DSOLID entities). Both are not implemented as stated in the repository readme. However, MTEXT is definitely the most important feature to implement next, so it the first position in my TODO list. There is probably no way for 3DSOLID since it has some proprietary data inside. 3DFACE should be quite simple but seems not to be so important because this viewer is designed as 2D only. But I still have this in my roadmap, and will try to find some time to implement both MTEXT and 3DFACE entities support.

vagran commented 2 years ago

I have just implemented limited support for MTEXT entity. So at least multiline text should appear now in this test file. @Leessonomy Is it possible to get your test file?

Leessonomy commented 2 years ago

@vagran sure https://ru.files.fm/u/su94k8t7f

vagran commented 2 years ago

Thanks. Multiline text is now rendered. I do not see points for some reason, however they are fully supported (including various styles via $PDMODE variable). I'll check it later. Solids are not displayed because SOLID group is not yet supported but I'll also implement this soon among with 3DFACE support.

vagran commented 2 years ago

I have added support for SOLID and 3DFACE. Also fixed problem with points rendering. Now the picture seems to be fully correct. @Leessonomy please also note that your reference picture has some problems: multiline text is not properly aligned (pxqc; not handled), and blocks are not properly colored. I verified it with the Autodesk online viewer.