search

vagran / dxf-viewer

DXF 2D viewer written in JavaScript
Mozilla Public License 2.0
290 stars 86 forks source link

Nice viewer, and some issues I found #66

Open yanzexuan1 opened 1 year ago

yanzexuan1 commented 1 year ago

Hello Vagran,

Nice to see your dxf-viewer, wonderful tool! We also created our own dxf viewer, but not open sourced! I tried your example web site, it already supports plenty of dxf features with a pretty good performance. Great job.

One file has some issue, as you can see, the color, and some hatches are not rendererd correctly. You may take a look when there is chance. image

The file is here: https://github.com/pattern-x/gemini-viewer-examples/blob/main/public/demo/models/dxf/rac_basic_sample_project.dxf

It looks like this in our system: https://pattern-x.github.io/gemini-viewer-examples/#/Rac_basic_sample_project_dwg image

vagran commented 1 year ago

Hello, Thanks for the report! Yes, solid hatch type is currently not implemented feature. A good sample file is the first step towards the implementation, so thanks for the example file. For non-solid pattern, at first look, it seems like a bug in handling custom patterns. And it is also the first example with such patterns defined in HATCH entity, so now I have a chance to fix and test it.