Return type of GetCamera()

vagran / dxf-viewer

DXF 2D viewer written in JavaScript

Mozilla Public License 2.0

290 stars 86 forks source link

Return type of GetCamera() #69

Closed shintarokkk closed 1 year ago

shintarokkk commented 1 year ago

Hi Thanks for creating and maintaining this great project!

I found a small bug in index.d.ts. I think return type of DxfViewer.GetCamera() should be "OrthographicCamera" instead of "Camera". https://github.com/vagran/dxf-viewer/blob/e07b8d93d93708dbffa161ea46e214430957874a/src/index.d.ts#L56

vagran commented 1 year ago

Hi, thanks for the report. I have fixed as proposed. However, it might change in the future, since 3D view is planned to implement, so perspective camera may be used as well.