Issue #171 Adding support for automatic configuration of host visibility on Windows

vagrant-landrush / landrush

A Vagrant plugin that provides a simple DNS server for Vagrant guests

MIT License

667 stars 78 forks source link

Issue #171 Adding support for automatic configuration of host visibility on Windows #204

Closed hferentschik closed 8 years ago

hferentschik commented 8 years ago

Making use of netsh and Windows registry to modify network configuration
Adding test harness

This works on Win 10. Needs review and if possible more testing.

hferentschik commented 8 years ago

@budhrg @bexelbie any comment? Probably hard to tell, since this is very Windows specific code, but maybe you have some general feedback or the ability to test on Windows.

coolbrg commented 8 years ago

@hferentschik Could you refer issue in the description? Handy in clicking instead of going through.

coolbrg commented 8 years ago

@hferentschik Will check functionally tomorrow.

hferentschik commented 8 years ago

@budhrg thanks for the code review. I'll apply the suggestions. I also find another issue during my tests on Windows 7 yesterday. Trying to resolve this this morning.

Will check functionally tomorrow.

You might want to hold of until my next update.

hferentschik commented 8 years ago

Closing this for now. Creating a new pull request.