Issue #262 Add --all flag to rm command

vagrant-landrush / landrush

A Vagrant plugin that provides a simple DNS server for Vagrant guests

MIT License

666 stars 78 forks source link

Issue #262 Add --all flag to rm command #266

Closed ezekg closed 7 years ago

ezekg commented 7 years ago

This will clear all Landrush host entries, resolving the issue of stale records building up over time as discussed in #262. There was already a Store#clear! method, so went ahead and utilized that.

Usage

vagrant landrush rm --all

Notes

There didn't seem to be an existing implementation for command line flags, so if you'd like to do something different/more extensible, let me know.

ezekg commented 7 years ago

Looks like the Command class may need a little bit of refactoring. 🚑

hferentschik commented 7 years ago

Seems some Rubocop violations are the reason for the test failures. Any chance you can massage the code it a bit more? Otherwise I can see what I can do. Overall you are doing the right thing.

ezekg commented 7 years ago

Yeah, no problem. I'll see if I can refactor the Command class a bit when I have some free time.

hferentschik commented 7 years ago

@ezekg I created pull request #287 which is based on your work, but addresses the rubocop issues and adding some tests. I hope this is ok with you.