search

vagrant-landrush / landrush

A Vagrant plugin that provides a simple DNS server for Vagrant guests
MIT License
668 stars 80 forks source link

Issue #346 Updating Vagrant dev version #347

Closed hferentschik closed 5 years ago

hferentschik commented 5 years ago

fix for issue #346

hferentschik commented 5 years ago

@davividal wdyt?

davividal commented 5 years ago

Looks nice for me. I'm currently having issues with bento/debian boxes when running on Mac. I'm still trying to understand the issue so I can write a test for it and solve. So, I see no problems in disabling some failing tests since I'm bound to look into that in the (very) near future.

hferentschik commented 5 years ago

Looks nice for me.

Cool.

I'm currently having issues with bento/debian boxes when running on Mac.

Anything which is reported? Which version of bento/debian? I am on macOS as well.

I'm still trying to understand the issue so I can write a test for it and solve.

Sounds good. Regarding the disabled test. It used to work, but it seems something has changed. See also #342.

The Cucumber tests are a great way to run through the most common use cases. Be aware, that if a Cucumber run fails you might have to manually check and kill a locally running Landrush process. I am looking into how to improve this. Probably by a beforeEach hook.

So, I see no problems in disabling some failing tests since I'm bound to look into that in the (very) near future.

+1