search

vagrant-landrush / landrush

A Vagrant plugin that provides a simple DNS server for Vagrant guests
MIT License
668 stars 80 forks source link

Rename VMware Fusion support to VMware Desktop #358

Open nickcharlton opened 4 years ago

nickcharlton commented 4 years ago

On 2016-03-26, HashiCorp released the VMware Desktop Plugin, which replaced the existing VMware Fusion implementation. With the rename, the hooks that Landrush needs to start services can no longer be called. Renaming those makes those work again.

Fixes #334.

davividal commented 4 years ago

I can't test this. But the tests passed, so I believe. :)

nickcharlton commented 4 years ago

I would've liked to have tested my changes too, but I couldn't work out how to do it. Running it locally, I found I wasn't able to run the tests for Landrush whilst having the (private) VMware provider plugin installed.

I don't suppose you have any suggestions?

davividal commented 4 years ago

I never used VMware + Vagrant, so no.

davividal commented 4 years ago

@hferentschik this one looks fine for me. What do you think?

nickcharlton commented 3 years ago

I'm conscious that this has been sat a little while without any activity. Is there anything I can help with to move this along?