vagrant-smartos / vagrant-smartos-zones

Manage SmartOS local zones in Vagrant
MIT License
54 stars 9 forks source link

plugin no longer pulls correct platform image if it's not already cached #33

Open bixu opened 9 years ago

bixu commented 9 years ago

During vagrant up when no platform image is cached:

INFO interface: error: An error occurred while downloading the remote file. The error
message, if any, is reproduced below. Please fix this error and try
again.

The requested URL returned error: 404 Not Found
An error occurred while downloading the remote file. The error
message, if any, is reproduced below. Please fix this error and try
again.

The requested URL returned error: 404 Not Found

Using a vagrant up with debug I get the following:

==> default: Downloading SmartOS platform image
 INFO downloader: Downloader starting download:
 INFO downloader:   -- Source: https://us-east.manta.joyent.com/Joyent_Dev/public/SmartOS//smartos-.iso
 INFO downloader:   -- Destination: /Users/helal/.vagrant.d/smartos/platform_images/.iso
 INFO subprocess: Starting process: ["/opt/vagrant/bin/../embedded/bin/curl", "-q", "--fail", "--location", "--max-redirs", "10", "--user-agent", "Vagrant/1.7.2", "--output", "/Users/helal/.vagrant.d/smartos/platform_images/.iso", "https://us-east.manta.joyent.com/Joyent_Dev/public/SmartOS//smartos-.iso"]

We think somehow that the variable being dropped is 'latest', maybe here?:

https://github.com/vagrant-smartos/vagrant-smartos-zones/blob/master/lib/vagrant/smartos/zones/util/platform_images.rb

cc/ @ahelal

sax commented 9 years ago

When using 'latest', it does a check to see what the latest version is and downloads it using the time stamped name.

If it can't connect to find the latest version, it's supposed to use the latest already installed locally.

I'll take a look later to see if I can reason about what's happening.

Sent from my iPhone

On Feb 19, 2015, at 5:35 AM, Blake Irvin notifications@github.com wrote:

During vagrant up when no platform image is cached:

INFO interface: error: An error occurred while downloading the remote file. The error message, if any, is reproduced below. Please fix this error and try again.

The requested URL returned error: 404 Not Found An error occurred while downloading the remote file. The error message, if any, is reproduced below. Please fix this error and try again.

The requested URL returned error: 404 Not Found Using a vagrant up with debug I get the following:

==> default: Downloading SmartOS platform image INFO downloader: Downloader starting download: INFO downloader: -- Source: https://us-east.manta.joyent.com/Joyent_Dev/public/SmartOS//smartos-.iso INFO downloader: -- Destination: /Users/helal/.vagrant.d/smartos/platform_images/.iso INFO subprocess: Starting process: ["/opt/vagrant/bin/../embedded/bin/curl", "-q", "--fail", "--location", "--max-redirs", "10", "--user-agent", "Vagrant/1.7.2", "--output", "/Users/helal/.vagrant.d/smartos/platform_images/.iso", "https://us-east.manta.joyent.com/Joyent_Dev/public/SmartOS//smartos-.iso"] We think somehow that the variable being dropped is 'latest', maybe here?:

https://github.com/vagrant-smartos/vagrant-smartos-zones/blob/master/lib/vagrant/smartos/zones/util/platform_images.rb

cc/ @ahelal

— Reply to this email directly or view it on GitHub.

sax commented 9 years ago

I'm not seeing this problem locally. Do you have any other settings in your Vagrantfile that might be interacting strangely with this code? Can you check out the latest version of master from github and binding.pry into this code to get more information?

Relevant lines: https://github.com/vagrant-smartos/vagrant-smartos-zones/blob/master/lib/vagrant/smartos/zones/util/platform_images.rb#L97-L101

That determines the latest version here: https://github.com/vagrant-smartos/vagrant-smartos-zones/blob/master/lib/vagrant/smartos/zones/util/platform_images.rb#L40-L45

Which uses these lines to generate URLs: https://github.com/vagrant-smartos/vagrant-smartos-zones/blob/master/lib/vagrant/smartos/zones/util/platform_images.rb#L111-L119

drscream commented 8 years ago

I took a short look and it works for me as well. If I configure the Vagrantfile correctly with the setting smartos1601.global_zone.platform_image = "latest" it works as expected.