Closed tanryberdi closed 1 year ago
@vaguecoder could you please review? 🙏 I disabled many linters, for examples (lll - length of line), we did not decide length of line, wdyt?
@tanryberdi A few things to update here. I'll update on respective files shortly.
The comments from .golangci.yml
are overloaded, even for an open-source project. Please remove all comments including the licensing part above.
The only things, as per me, require comments here are:
issues
section. Not the default values and all, but if you have excluded some linter for a specific reason.linters-settings
section. Not the default values and all, but if you have linter configured.I just did some trial and error and found the following are the minimum settings we require as of now for the above 2 sections:
linters-settings:
cyclop:
max-complexity: 30
nolintlint:
allow-unused: true
issues:
exclude-rules:
- path: "_test\\.go"
linters:
- bodyclose
- noctx
I'm turning my back on my original request. Let's stick to this minimal settings and we can have future issues to add or configure more linters.
Please keep the linters that you've enabled so far and remove the comments describing them.
Also, I ask one more request of you on the same. Please add TODO
against
cyclop
- to reduce the complexitynolintlint
- to fix this (I believe you added inline comments wherever nolint
is specified)bodyclose
- to close the bodynoctx
- to check if we can really use context
in these placesWe'll address these in future issues.
See #4