vahidhedayati / grails-wschat-plugin

Grails websocket chat Plugin provides a multi-chat room add-on to an existing grails based site. provides: Private Messaging/WebRTC/Offline PM + room booking/reservations. Websocket TicTactoe. Add Live Chat to your Grails application
http://grails.org/plugin/wschat
Apache License 2.0
22 stars 10 forks source link

WebRTC= new WebRTC() is incorrect #15

Closed zeneye closed 8 years ago

zeneye commented 8 years ago

The right is, I think, webRTC= new WebRTC()
this code appare in several files

vahidhedayati commented 8 years ago

it appears in two places and as it is - appears to be correct:

grails-app/views/wsChat/webrtcrec.gsp:var WebRTC = new WebRTC();
grails-app/views/wsChat/webrtcsend.gsp:var WebRTC = new WebRTC();

Those files one called by sender and one by receiver.

It may be the actual comment that has misleaded you that appears above multiple blocks:

grep "create new WebRTC-Object" -r -A1 *|grep -v matches
--
build/resources/main/wsChat/webrtcrec.gsp://create new WebRTC-Object
build/resources/main/wsChat/webrtcrec.gsp-var WebRTC = new WebRTC();
--
build/resources/main/wsChat/camsend.gsp:        // create new WebRTC-Object
build/resources/main/wsChat/camsend.gsp-        var WebCam = new WebCam();
--
build/resources/main/wsChat/webrtcsend.gsp:// create new WebRTC-Object
build/resources/main/wsChat/webrtcsend.gsp-var WebRTC = new WebRTC();
--
build/resources/main/wsChat/camrec.gsp: // create new WebRTC-Object
build/resources/main/wsChat/camrec.gsp- var WebCamRec = new WebCamRec();
--
grails-app/views/wsChat/webrtcrec.gsp://create new WebRTC-Object
grails-app/views/wsChat/webrtcrec.gsp-var WebRTC = new WebRTC();
--
grails-app/views/wsChat/camsend.gsp:        // create new WebRTC-Object
grails-app/views/wsChat/camsend.gsp-        var WebCam = new WebCam();
--
grails-app/views/wsChat/webrtcsend.gsp:// create new WebRTC-Object
grails-app/views/wsChat/webrtcsend.gsp-var WebRTC = new WebRTC();
--
grails-app/views/wsChat/camrec.gsp: // create new WebRTC-Object
grails-app/views/wsChat/camrec.gsp- var WebCamRec = new WebCamRec();

Each one is doing a different thing, please let me know if I am missing something here.

vahidhedayati commented 8 years ago

I think this is not an issue ? Please re-open if I have missed something