Create 1-challenge.c - Githubissues

vaib-dev / Courses

Course for understanding GitHub, Data Structures, Algorithms, Software Engineering, DBMS, Computer-Networks, Scrum, Adobe-Illustrator, LinkedIn and Freelance from scratch.

12 stars 7 forks source link

Create 1-challenge.c #28

Closed vaib-dev closed 4 years ago

vaib-dev commented 4 years ago

This code is working for the first input mentioned in the issue .Update will be uploaded in a short period.

udeysingh95 commented 4 years ago

Can you post pictures of output when you are entering these values?

udeysingh95 commented 4 years ago

I meant with output - here, in a comment only. Add images here not in repo. For now, there's a png file in greedy folder. We don't need that. Just in comments on this PR.

vaib-dev commented 4 years ago

Output challenge-1

udeysingh95 commented 4 years ago

Out of 11999 is wrong. There's no 10000rs note in India. Need to check it there.

udeysingh95 commented 4 years ago

New screenshots please

udeysingh95 commented 4 years ago

For this time - it is fine. But you have created hash.c on challenge branch. this branch was supposed to have only challenge code and updated readme. Next time - don't overload irrelevant stuff on one branch always. it makes it difficult to review. Because then there are too many things to review on a single branch. As I said - for now, it is ok.

[x] add the new outputs here in comments - a picture or just copy past here - both are ok

vaib-dev commented 4 years ago

Screenshot (2) Screenshot (14)

udeysingh95 commented 4 years ago

cool work. all sorted till here.