search

vaibhavsingh97 / random-word

This is a simple python package to generate random english words
https://pypi.org/project/random-word/
MIT License
123 stars 25 forks source link

Don't mix camelCase and underscore_case #21

Open ErikBoesen opened 5 years ago

ErikBoesen commented 5 years ago

Is your feature request related to a problem? Please describe. I love this project, but don't like how it mixes camel case (i.e. for parameter names) with underscore (i.e. function names).

Describe the solution you'd like Choosing one and sticking with it; preferably underscore_case as that's Python standard.

Describe alternatives you've considered N/A

Additional context I am happy to implement this myself if you say I can.

ErikBoesen commented 5 years ago

I know this would kind of screw up backward compatibility. For a time it might be appropriate to simply support both, then phase out the old style eventually, and people who want to keep using the old version can simply limit their version.

vaibhavsingh97 commented 5 years ago

Hi @ErikBoesen 👋 Thanks for the love for this project, I am very glad you liked the project ❤.

don't like how it mixes camel case (i.e. for parameter names) with an underscore

I tried to follow PEP 008, please let me know, where I violated and would welcome a PR to fix the issue. Thanks for helping me out 🙌