search

vaibhavsingh97 / random-word

This is a simple python package to generate random english words
https://pypi.org/project/random-word/
MIT License
123 stars 25 forks source link

updated unit tests #4

Closed jatin69 closed 6 years ago

jatin69 commented 6 years ago

solves issue #3

test-cases

jatin69 commented 6 years ago

Travis build fails. Logs say it's because the command to decrypt the config file failed. It's unlikely that's its caused by this commit. Maybe check the build logs for more info.

vaibhavsingh97 commented 6 years ago

@jatin69 One suggestion, never send PR through your master branch. Always create a new branch before sending new PR.

vaibhavsingh97 commented 6 years ago

@jatin69 The keys needed to decrypt are set as two environment variables ($encrypted_619c3c835fae_key and $encrypted_619c3c835fae_iv) in the repository settings of travis-ci. On forks and pull requests those secure variables aren't available, so the openssl command fails and Hence Travis Fails 😄

Ref: https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions

jatin69 commented 6 years ago

Thanks, man. I hope this does the job.

vaibhavsingh97 commented 6 years ago

Awesome!! @jatin69, one last thing, can you squash your commits into one 😄

jatin69 commented 6 years ago

@vaibhavsingh97 I already committed them to remote master branch. Online I found we can squash a branch, but I didn't create a branch (lesson learned) & did it all in the master branch. How to squash them now? A little help? soft reset HEAD^5 & commit?

vaibhavsingh97 commented 6 years ago

@jatin69 You can use git reset --soft HEAD~7 but after that, you have to force push to the remote branch. In this case, it's master. So before pushing changes, you should check where is HEAD points to. You can use git log --oneline to check commit logs. Alternatively, you can use git rebase -i HEAD~7 and let first commit to pick and pass the others to squash and force push it.

jatin69 commented 6 years ago

@vaibhavsingh97 I honestly didn't understand most of it. Needs more practice with git. Meanwhile, I sent a new pull request with a single commit. That should be good to go. 🚀

vaibhavsingh97 commented 6 years ago

@jatin69 you should not give up, just try to learn. I do agree it's tough to understand but not impossible. Next time don't gave up this early 😄