search

vaibhavsingh97 / random-word

This is a simple python package to generate random english words
https://pypi.org/project/random-word/
MIT License
123 stars 25 forks source link

Updated README and added an optional argument #58

Open RapidCompiler opened 3 years ago

RapidCompiler commented 3 years ago

I have updated the README.md file for v1.0.5, which mentions that the user can also use their personal API keys. Also, added an optional parameter 'length' in the get_random_word() and get_random_words() functions which reduces the function call's verbosity when a word of an certain length is required.

This solves three issues in total #49 #22

RapidCompiler commented 3 years ago

Please do review this pull request and tell me the changes I need to incorporate in order to pass all the tests. I really haven't changed it a whole lot. So, I don't know what's making it fail.

vaibhavsingh97 commented 3 years ago

Please do review this pull request and tell me the changes I need to incorporate in order to pass all the tests. I really haven't changed it a whole lot. So, I don't know what's making it fail.

It's not your fault, as to run tests, I had encrypted API key and committed to the git. Every time, a build is triggered SECRET key which I had added in the repository get accessed and decrypt the file. But there is an exception that SECRET Key can not be passed to the build triggered from forked repositories. I would fix this probably later, or if you want to hack into it than a PR is welcome.

RapidCompiler commented 3 years ago

Please do review this pull request and tell me the changes I need to incorporate in order to pass all the tests. I really haven't changed it a whole lot. So, I don't know what's making it fail.

It's not your fault, as to run tests, I had encrypted API key and committed to the git. Every time, a build is triggered SECRET key which I had added in the repository get accessed and decrypt the file. But there is an exception that SECRET Key can not be passed to the build triggered from forked repositories. I would fix this probably later, or if you want to hack into it than a PR is welcome.

Please do review this pull request and tell me the changes I need to incorporate in order to pass all the tests. I really haven't changed it a whole lot. So, I don't know what's making it fail.

It's not your fault, as to run tests, I had encrypted API key and committed to the git. Every time, a build is triggered SECRET key which I had added in the repository get accessed and decrypt the file. But there is an exception that SECRET Key can not be passed to the build triggered from forked repositories. I would fix this probably later, or if you want to hack into it than a PR is welcome.

So, how do I fix this? Can we not create a feature branch on this repository and give me access to that branch alone, so that it would be easier? Also, if all forked repos PR's are failing builds, isn't that a bad thing? Because no where does it say that the builds would definitely fail and I never even knew until you told me. Second question is, why do you need to encrypt an API key on an open source repo?