vaibhavsingh97 / random-word

This is a simple python package to generate random english words
https://pypi.org/project/random-word/
MIT License
123 stars 25 forks source link

Updated Documentation #7

Closed igagankalra closed 6 years ago

vaibhavsingh97 commented 6 years ago

@igagankalra The best practices say that always reference your PR to the opened issue and before sending PR, claim an open issue. This help maintainer a lot, To read more about closing the issue, read it here: https://help.github.com/articles/closing-issues-using-keywords/

igagankalra commented 6 years ago

@vaibhavsingh97 In Development section I have to add all the things you mentioned above? same at it is.

vaibhavsingh97 commented 6 years ago

@igagankalra yes

igagankalra commented 6 years ago

@vaibhavsingh97 I'll update this documentation in my that new feature PR, is that okay with you and just have a look at the error I have sent you.

vaibhavsingh97 commented 6 years ago

@igagankalra It would be better if you solve issues in separate PR. Thanks

vaibhavsingh97 commented 6 years ago

@igagankalra This is not how you can fix Travis, Please revert back the changes made in travis.yml. This is a known issue as Travis had restricted pull request to access encrypted variables in PR so that's why Travis is failing here.

And By adding

- 'if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then bash ./travis/run_on_pull_requests; fi'
- 'if [ "$TRAVIS_PULL_REQUEST " = "false" ]; then bash ./travis/run_on_non_pull_requests; fi'

they means instead of run_on_pull_requests you add your custom scripts, so have to figure it out how to pass test in Travis without exposing API key.

igagankalra commented 6 years ago

@vaibhavsingh97 Now everything has been updated properly now close that issue and accept the pull request. Thank you.

vaibhavsingh97 commented 6 years ago

Also, please squash your commits into one. Ref: https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git

vaibhavsingh97 commented 6 years ago

@igagankalra I am talking about these whitespace 😅 image image

Remove the highlighted whitespace from all the code snippets

vaibhavsingh97 commented 6 years ago

@igagankalra Any updates?