search

vaibkumr / yTermPlayer

Stream youtube playlists as audio on linux terminal
GNU General Public License v3.0
267 stars 22 forks source link

Full gitignore, travis ci setup file, readme badge and codacy edits #6

Closed SamSamhuns closed 5 years ago

4shadoww commented 5 years ago

Could you add to the key bindings section new key bindings: key "u" for volume up and "d" for volume down? I forgot to do that update to the read me when I made #5 pull request.

SamSamhuns commented 5 years ago

Could you add to the key bindings section new key bindings: key "u" for volume up and "d" for volume down? I forgot to do that update to the read me when I made #5 pull request.

Done.

ceoro9 commented 5 years ago

@SamSamhuns also in readme under installation section, version of packages are out-dated. Can you please make them correspond the requirements.txt. But to be fair I would rather completely remove such installation option, idk.

SamSamhuns commented 5 years ago

@SamSamhuns also in readme under installation section, version of packages are out-dated. Can you please make them correspond the requirements.txt. But to be fair I would rather completely remove such installation option, idk.

Yes, I believe it is better to remove the version numbers in the req. These packages should be backward compatible in updated versions.

vaibkumr commented 5 years ago

Thank you everyone for your contributions!