vaidik / commentjson

Add JavaScript or Python style comments in JSON.
MIT License
104 stars 25 forks source link

Added support for python 3.x. Fixes #3 #11

Closed esafak closed 7 years ago

esafak commented 9 years ago

It was not working in OS X either, so I took the liberty of making a few changes without breaking backward compatibility.

p.s.: @vaidik might like to set up automatic deployment to pypi.

vaidik commented 9 years ago

@esafak thanks for taking out time to fix this. I really appreciate it. Left just one comment. Looks good otherwise.

gabyx commented 9 years ago

please merge this :-)

mverleg commented 9 years ago

+1 would be very useful

mverleg commented 7 years ago

Ehm nothing changed?

esafak commented 7 years ago

@mverleg PR #13 was merged instead.

mverleg commented 7 years ago

Afraid it didn't fix it for me, I cloned just before posting that comment and

python3 -c 'import commentjson'

doesn't work for me (but python2 does).

esafak commented 7 years ago

I just tested and you seem to be right. @vaidik can take it from here.