search

vaidik / commentjson

Add JavaScript or Python style comments in JSON.
MIT License
104 stars 25 forks source link

python3.x compatibility #15

Closed buxx closed 5 years ago

buxx commented 7 years ago

Some changes to python 3.x. Working travis for following versions:

girtsf commented 7 years ago

FYI, this pull request makes it work on 3.5 for me.

jrosebr1 commented 7 years ago

@vaidik Can this pull request please be merged in? Thanks!

johanneswilm commented 7 years ago

@buxx @girtsf @jrosebr1 It looks like @vaidik has become unresponsive (maybe dead?). What do you guys say toward creating a new pypi package and then continuing it there? We really need a pypi-released version that is compatible with Python3. The name really does not matter. @buxx would you be up for releasing a package called something like "strip-json-comments" or some other such thing with your code?

jrosebr1 commented 7 years ago

@johanneswilm I'm interested but I wouldn't want to be the only maintainer as I'm quite busy. If others are willing to work on the project I would be willing to have the repo under my account.

johanneswilm commented 7 years ago

@jrosebr1 Great! I just found JSON.minify which seems to provide the same functionality and have the same issue [1]. Hopefully we can get one of the two projects up and running on pypi.

[1] https://github.com/getify/JSON.minify/issues/21

johanneswilm commented 7 years ago

@jrosebr1 It looks like the other project is willing to maintain the pypi package of JSON_minify [1]. And as far as I can tell, it provides the same functionality.

[1] https://pypi.python.org/pypi/JSON_minify

buxx commented 7 years ago

@johanneswilm Thank's for sharing, i will use JSON_minify to !

jrosebr1 commented 7 years ago

@johanneswilm So to confirm, we're going to use JSON_minify now? Just want to make sure :-)

johanneswilm commented 7 years ago

I have switched, yes. There is now a current release of it on pypi and we have a way to get new releases out. Unless the situation with commentjson changes, I suggest we do that. It sounds like they are also open to give write access to more people should you be interested.

gabyx commented 7 years ago

Why is this not merged :-)

gabyx commented 7 years ago

If @vaidik is no more responsing, there should be other maintainers who can merge this :-)

johanneswilm commented 7 years ago

@gabyx I don't know if there is a mechanism by which one can challenge package maintainership on pypi. For now the simplest is to switch to https://pypi.python.org/pypi/JSON_minify

vaidik commented 5 years ago

Hi Everyone,

Not dead just yet. :)

First of all, apologies for going missing for such a long time. I had just switched jobs around the time when conversations were going on here.

I had added support for python 3 a few months back. It should be possible for you to use commentjson with Python 3.

Supporting the library has been hard with my other commitments. If anyone of you wants to volunteer to maintain, I'd be more than happy to accept participation.