search

vaidik / commentjson

Add JavaScript or Python style comments in JSON.
MIT License
104 stars 25 forks source link

Test latest Lark changes to reconstructor #45

Closed erezsh closed 4 years ago

erezsh commented 4 years ago

We accepted a pull-request to Lark for the reconstructor that makes it faster, and better at handling ambiguity. Everything should still work as before, and the speed should increase.

But, the change is big enough that we might have missed something.

Any chance you could check-out the latest lark-parser:master and let me know if there's a problem with it? I don't plan to make a release in the next few weeks, but I bet you'd want to vet it before I do.

(This is the commit, if you're interested: https://github.com/lark-parser/lark/commit/f84a964463fed83256bff617992115f7733dd81f)

I'm also curious if you notice an improvement in performance, but that's less crucial.

vaidik commented 4 years ago

Thanks for following up on this. I will do this over the weekend and let you know about my test results.

vaidik commented 4 years ago

I tested this out locally with your commit. I don't see any problem. Should be good for release from my side.

If you want, I can test it again right before you are making the release.