search

vaimee / desmo-dapp

0 stars 1 forks source link

Issue#4 refactoring scripts #10

Closed FerrariAndrea closed 2 years ago

FerrariAndrea commented 2 years ago

Warn: this PR includes the fixes on the branch issue#2_callbackhell, this branch has already been merged with issue#2_callbackhell.

relu91 commented 2 years ago

@FerrariAndrea no worries about the scripts now. After my commit 6da6232 the situation is better but it is still hard to make it work. Please finish what @hyperloris asked then I'll take over some points.

relu91 commented 2 years ago

Also the start script depends on the resolution of #1 .

FerrariAndrea commented 2 years ago

Note: when that PR will be merged, remember to change the Dockerfile, I think the path of the application inside the Dokerfile will need an update. Removing the "exclude" from "tsconfig.json" the path of the build files is changed, from build/app.js to build/src/app.js.

The Dockerfile that is in that PR is useless, and not updated to the Dockerfile of PR #12.