search

vaimo / composer-patches

Applies a patch from a local or remote file to any package that is part of a given composer project. Patches can be defined both on project and on package level. Optional support for patch versioning, sequencing, custom patch applier configuration and composer command for testing/troubleshooting patches.
MIT License
287 stars 40 forks source link

PHP 8.2 deprecation message "Creation of dynamic property" #104

Closed michaelarnauts closed 1 year ago

michaelarnauts commented 1 year ago

A clear and concise description of what the bug is.

Pre-requisites

  1. Use PHP 8.2

To Reproduce Steps to reproduce the behavior:

  1. Install the package

Actual The output of composer install contains this warning:

Deprecation Notice: Creation of dynamic property Vaimo\ComposerPatches\Patch\File\Applier::$applierErrorFactory is deprecated in /opt/app/vendor/vaimo/composer-patches/src/Patch/File/Applier.php:63
hostep commented 1 year ago

Yep, also running into this. It's just a warning, but still, would be nice to see this fixed soon-ish (Magento 2.4.6 comes with PHP 8.2 support and will be released in about 3 weeks) 🙂

Thanks!

zamoroka commented 1 year ago

@hostep @michaelarnauts thanks for your contribution. The fix is released in 5.1.1

hostep commented 1 year ago

Thank you very much!