search

vain / pdfPres

[Discontinued] Dual head PDF presenter: Current slide with context + current slide in fullscreen (Linux, BSD).
http://www.uninformativ.de/projects/_discontinued/pdfpres/
17 stars 10 forks source link

remove popplergdk #39

Closed t-8ch closed 12 years ago

t-8ch commented 12 years ago

this removes the need for popplergdk.{c,h} and its lowlevel magic. It also includes some random fixes.

This introduces a bug when changing the layout mode which make the main window unuseable. But as the layout of the mainwindow has to be rewritten anyway I left it this way. Without changing the layout mode everything seems fine. At least on Archlinux with i3-wm.

PS.: I may have found a way to change the branch to pull into: Where it shows you my and your branch in the black boxes click one of the boxes (this works when creating the pull request)

vain commented 12 years ago

Thank you! I'll look into this soon. I have almost no idea about all that Gtk3 stuff yet and I'll have to catch up with you.

A quick test: The beamer window is almost completely black. It appears we'll have to set a background color for cairo to render on. Don't ask me what's happening there. I agree, though, all that "popplergdk.*" stuff has to be removed.

t-8ch commented 12 years ago

If I understand correctly all this PixBuf stuff should go, too. As Gtk does nearly all rendering with cairo it looks quite wrong to feed PixBufs to cairo. I'm writing a benchmark to check if the cache is needed at all. The answer for the moment: No (there is more testing to be done)

So please forget this pull request (except those trivial fixes, but I could open another pull request for those)

t-8ch commented 12 years ago

Here is an example for direct rendering with cairo. https://gist.github.com/2926027

The only thing to cache would be the intermediate cairo_t. The rendering from cairo_t to screen will be hardwareaccelerated anyway

vain commented 12 years ago

Alright, based on your pull request and gist, I'm currently trying to establish a clean code base that uses GdkDrawingArea and cairo.

Please excuse my slow pace. Turbulent times. :-)

vain commented 12 years ago

Thanks again for your work. popplergdk* and pixbuf* is no longer needed on the gtk3 branch.