search

vaipatel / morphops

Geometric Morphometrics in Python
https://morphops.readthedocs.io/en/latest/
MIT License
27 stars 4 forks source link

Move contributors list directly to README_for_docs. Regen README. #20

Closed vaipatel closed 3 years ago

vaipatel commented 3 years ago

Could not get the contributors list rendered correctly in #19. Just copy the list directly to the README_for_docs for now, and then possibly do away with the whole README_for_docs included in the the index.rst and autogen README business, and just use a README.md like the rest of GitHub.

hakonanes commented 3 years ago

I cannot see the RtD building the docs as part of the PR checks: do you know the reason for this? I sometimes forget to save the changes I make to the RtD settings by clicking the "save" button at the bottom...

vaipatel commented 3 years ago

Yea I noticed that this time around as well. It looks like my GitHub account wasn't connected correctly for whatever reason, although I could see it listed under "Connected Services" in the Admin dashboard. And so I think I was hitting the "Build status is not being reported to your VCS provider" problem list in the Troubleshooting section.

Anyway I ended up reconnecting my account and reauthorizing RtD (and the fact that it just let me without much resistance makes me feel even more like the OAuth was not setup correctly the first time around..)

So here's hoping it's all set up correctly now.. As a test, when I went to reconnect again, no action was taken and instead I got a friendly print on the Admin page saying "The social account has been connected.".

hakonanes commented 3 years ago

Makes sense, we'll see upon the next PR!