Open davelab6 opened 8 years ago
I've put together a project checklist which has a section on vertical metrics and currently Akaya Kanadaka doesn't follow them:
$ fontbakery-fix-vertical-metrics.py *tf WARNING: AkayaKanadaka.ttf has NOT even heights Parameter AkayaKanadaka.ttf ymax 958 hhea.ascent 950 OS/2.sTypoAscender 750 OS/2.usWinAscent 950 ymin -834 hhea.descent -1000 OS/2.sTypoDescender -250 OS/2.usWinDescent 1000 hhea.lineGap 0 OS/2.sTypoLineGap 1000 hhea total 1950 typo total 2000 win total 1950 UPM:Heights 1000:1792 UPM:Heights % 179 % High Glyphs AkayaKanadaka.ttf: Aring Uring
The values should be:
$ fontbakery-fix-vertical-metrics.py --autofix *tf $ fontbakery-fix-vertical-metrics.py *fix Parameter AkayaKanadaka.ttf.fix ymax 958 hhea.ascent 958 OS/2.sTypoAscender 958 OS/2.usWinAscent 958 ymin -834 hhea.descent -834 OS/2.sTypoDescender -834 OS/2.usWinDescent 834 hhea.lineGap 0 OS/2.sTypoLineGap 0 hhea total 1792 typo total 1792 win total 1792 UPM:Heights 1000:1792 UPM:Heights % 179 %
I'll make a pull request to address this
Have made a few metrics changes according to this in the latest update. Do take a look and let me know if it needs further tweaking.
I've put together a project checklist which has a section on vertical metrics and currently Akaya Kanadaka doesn't follow them:
The values should be:
I'll make a pull request to address this