getRecursiveMetadata discards data

adjenks commented 5 years ago

Let me start by saying great library. Well written.

The issue is that Client->getRecursiveMetadata() discards all but the first document.

getRecursiveMetadata() calls Metadata::make($response, $file); and make() is defined like so:

    /**
     * Return an instance of Metadata based on content type
     *
     * @param   string  $response
     * @param   string  $file
     * @return  \Vaites\ApacheTika\Metadata\Metadata
     * @throws  \Exception
     */
    public static function make($response, $file)
    {
        // an empty response throws an error
        if(empty($response) || trim($response) == '')
        {
            throw new Exception('Empty response');
        }

        // decode the JSON response
        $json = json_decode($response);

        // get the meta info
        $meta = is_array($json) ? current($json) : $json; //------ Only keeps first element if it's an array.

        // exceptions if metadata is not valid
        if(json_last_error())
        {
            $message = function_exists('json_last_error_msg') ? json_last_error_msg() : 'Error parsing JSON response';

            throw new Exception($message, json_last_error());
        }

        // get content type
        $mime = is_array($meta->{'Content-Type'}) ? current($meta->{'Content-Type'}) : $meta->{'Content-Type'};

        // instance based on content type
        switch(current(explode('/', $mime)))
        {
            case 'image':
                $instance = new ImageMetadata($meta, $file); //------ Only uses first element if array
                break;

            default:
                $instance = new DocumentMetadata($meta, $file); //------ Only uses first element if array
        }

        return $instance; //------ Instance built and returned using only first element if array
    }

(Lines of interest highlighted with //------)

I would suggest refactoring to have getRecursiveMetadata() return an Array, or a new object class like IterableMetadata that implements the Iterable interface.

adjenks commented 5 years ago

To create an example file, just attach a word document to an email and parse it.

vaites commented 5 years ago

Thanks @adjenks, will take a look. I think you're right... This method was implemented to save calls, not thinking on multiple files. Need to think how to implement it...

adjenks commented 5 years ago

@vaites Cool, thank you for making the library.

vaites commented 5 years ago

Can I ask you what version of PHP are you using?.

adjenks commented 5 years ago

@vaites PHP 7.1.33