Closed pandamouse closed 1 month ago
Sorry for taking such a long time to review this. DO you have any idea if this will break older jQuery versions?
Sorry for taking such a long time to review this. DO you have any idea if this will break older jQuery versions?
It will not break older jQuery version.
I'm just putting those event properties inside the 'on' property. You can see them use that as an example for jQuery 1.8 https://api.jquery.com/jQuery/#jQuery-html-attributes (when they first allow this kind of declaration where you chuck in any jQuery.fn as a property).
…shorthand is deprecated
jquery-migrate-3.4.1.source.js:137 JQMIGRATE: jQuery.fn.keydown() event shorthand is deprecated etc etc