Compiler errors in XCode

val-bubbleflat / laravel-echo-ios

A wrapper for Laravel Echo in Swift

MIT License

22 stars 17 forks source link

Compiler errors in XCode #5

Closed jdavidbakr closed 5 years ago

jdavidbakr commented 6 years ago

I'm unable to compile this in my project, I'm getting the following errors:

Incorrect argument labels in call (have 'socketURL:config:', expected 'manager:nsp:') (SocketIOConnector.swift:connect() line 54)

Cannot force unwrap value of non-optional type 'String' (SocketIOConnector.swift:socketId() line 148)

jdavidbakr commented 6 years ago

I was able to get around the issue by adding this to my Podfile:

pod 'Socket.IO-Client-Swift', '12.1.3'

The normal install was installing version 13.2.1 which must have had breaking changes. Not familiar enough with cocoapods to know how to modify the Podfile to prevent version 13.x from being installed, or I'd submit a pull request.

jdavidbakr commented 5 years ago

I've submitted a pull request to bring this up to use Socket.IO-Client-Swift version 13 as well as Swift 5